Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Jean THOMAS, Alexander Goncharov.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878 )
Change subject: dirtyjtag: Add DirtyJTAG programmer ......................................................................
Patch Set 11: Code-Review+1
(3 comments)
File dirtyjtag_spi.c:
https://review.coreboot.org/c/flashrom/+/67878/comment/32007aec_1db098cf PS10, Line 79: unsigned char *
`libusb_bulk_transfer`'s data parameter takes a non-const pointer (because this function can be both […]
Ack, there's a way to avoid casting away the `const`: not using `const` to begin with. See comment on latest patchset.
File dirtyjtag_spi.c:
https://review.coreboot.org/c/flashrom/+/67878/comment/8eca82ec_5cc66017 PS11, Line 74: const Let's drop the `const` from the parameter, so that the `const` doesn't need to be cast away.
https://review.coreboot.org/c/flashrom/+/67878/comment/6bcb33cd_a0092120 PS11, Line 167: const This `const` would also need to be dropped.
-
Angel Pons (Code Review)