Attention is currently required from: Nikolai Artemiev, Sergii Dmytruk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64375 )
Change subject: spi25_statusreg.c: Allow opaque masters to hook spi_{rw}_register()
......................................................................
Patch Set 1:
(1 comment)
File include/programmer.h:
https://review.coreboot.org/c/flashrom/+/64375/comment/bd1ad185_bb1e2db8
PS1, Line 409: int (*write_status) (const struct flashctx *flash, int status);
+1, these should take a register argument and should also both return status codes. […]
Done. Regarding can_{rw}_register(), a ret<0 could indicate it is not supported by the backing master?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64375
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3ab0d7f5f48338c8ecb118a69651c203fbc516ac
Gerrit-Change-Number: 64375
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Fri, 20 May 2022 05:43:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment