Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59072 )
Change subject: [RFC][WPTST] dummyflasher: add SR2 emulation harness ......................................................................
Patch Set 11:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/59072/comment/22a72bd7_5fd1b6c4 PS10, Line 11:
You've probably tested this patch, probably by running dummyflasher with some programmer params. […]
This change can't be tested through CLI on its own, it's more of a preparation for WP emulation. Future commits make it testable indirectly.
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/59072/comment/4dcfdb42_f07d847b PS10, Line 47: uint8_t emu_status_len; /* number of emulated status bytes */
Is this a number of emulated status bytes in SR2?
No, it's number of emulated status bytes in this chip (1 or 2). Datasheets usually present several registers as bytes of some imaginary status register that includes them all. Changed to "registers".
https://review.coreboot.org/c/flashrom/+/59072/comment/6f66a7cc_81805134 PS10, Line 342: /* XXX: Else reset SR2 parts to zero? */
What does it mean? Is it a TODO?
Sort of, but a questionable one. I wasn't sure what should happen in this case, but now found that W25Q128FV doesn't reset SR2 (older Winbound chips reset a couple of bits there).
https://review.coreboot.org/c/flashrom/+/59072/comment/c4a6be6f_45e6e3ff PS10, Line 930: data->emu_status_len = 1;
Maybe I missed something, but is this value always initialised to 1?
It is always 1 here, SR2 is used in the next commit. This change adds code that's not chip-specific.
File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/59072/comment/c8cbf16f_ba2fc65b PS10, Line 781: is an 8-bit or 16-bit hexadecimal value.
What does this value mean? I know it was like this before ;) But since you are changing/upgrading th […]
I think beginning of the sentence covers it:
You can specify the initial content of the chip's status register with the
Also added to the description a bit.
-
Sergii Dmytruk (Code Review)