Change in flashrom[master]: flashchips: Add W25Q256JV support - flashrom-gerrit

29 Oct 2018


      David Hendricks has posted comments on this change. ( https://review.coreboot.org/29305 )
Change subject: flashchips: Add W25Q256JV support
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29305/1/flashchips.c
File flashchips.c:
https://review.coreboot.org/#/c/29305/1/flashchips.c@15561
PS1, Line 15561: 		/* FOUR_BYTE_ADDR: supports 4-bytes addressing mode */
...
doesn't add any information (I guess the copied comment above is only a leftover)
Agreed, the comment is stale. We should probably clean up all those in a follow-up patch.
-- 
To view, visit https://review.coreboot.org/29305
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d7362777d364594d2a733d7e478741b0bef7c4
Gerrit-Change-Number: 29305
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 29 Oct 2018 22:50:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No