Change in flashrom[master]: pony_spi.c: Extract out get_params to simplify init - flashrom-gerrit

26 Apr 2022


      Attention is currently required from: Nico Huber, Paul Menzel, Edward O'Callaghan, Angel Pons, Light.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63130 )
Change subject: pony_spi.c: Extract out get_params to simplify init
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63130/comment/dc3d9f6e_260ca793 
PS5, Line 9: function pony_init_spi)`,
I would appreciate if you move this to the next line. I would just remove it, mentioning the commit ID should be enough IMO.
https://review.coreboot.org/c/flashrom/+/63130/comment/2b83e8d0_45bdbb78 
PS5, Line 10: number of
same here
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/63130
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I364febc05c870683cbad114583762b0c006f4bac
Gerrit-Change-Number: 63130
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Light aarya.chaumal@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Light aarya.chaumal@gmail.com
Gerrit-Comment-Date: Tue, 26 Apr 2022 01:05:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment