Medicine Yeh has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48688 )
Change subject: dediprog.c: Fix segmentation fault on no device found ......................................................................
dediprog.c: Fix segmentation fault on no device found
libusb_exit() call is done by dediprog_open() under the ret == 1 condition. Removing this line has no impact on any flow and side effect of the program.
Change-Id: I38b3f3ee3f9d46845df1404791f4a4782320aa7c Signed-off-by: Medicine Yeh medicinehy@gmail.com --- M dediprog.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/48688/1
diff --git a/dediprog.c b/dediprog.c index a9d0034..c50e374 100644 --- a/dediprog.c +++ b/dediprog.c @@ -1188,7 +1188,6 @@ ret = dediprog_open(i); if (ret == -1) { /* no dev */ - libusb_exit(usb_ctx); return 1; } else if (ret == -2) { /* busy dev */
Hello build bot (Jenkins), Stefan Reinauer, Edward O'Callaghan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/48688
to look at the new patch set (#2).
Change subject: dediprog: Fix segmentation fault on no device found ......................................................................
dediprog: Fix segmentation fault on no device found
libusb_exit() call is done by dediprog_open() under the ret == 1 condition. Removing this line has no impact on any flow and side effect of the program.
Change-Id: I38b3f3ee3f9d46845df1404791f4a4782320aa7c Signed-off-by: Medicine Yeh medicinehy@gmail.com --- M dediprog.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/48688/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48688 )
Change subject: dediprog: Fix segmentation fault on no device found ......................................................................
Patch Set 2: Code-Review+2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48688 )
Change subject: dediprog: Fix segmentation fault on no device found ......................................................................
Patch Set 2: Code-Review+2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48688 )
Change subject: dediprog: Fix segmentation fault on no device found ......................................................................
Patch Set 2: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/48688 )
Change subject: dediprog: Fix segmentation fault on no device found ......................................................................
dediprog: Fix segmentation fault on no device found
libusb_exit() call is done by dediprog_open() under the ret == 1 condition. Removing this line has no impact on any flow and side effect of the program.
Change-Id: I38b3f3ee3f9d46845df1404791f4a4782320aa7c Signed-off-by: Medicine Yeh medicinehy@gmail.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/48688 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M dediprog.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
diff --git a/dediprog.c b/dediprog.c index a9d0034..c50e374 100644 --- a/dediprog.c +++ b/dediprog.c @@ -1188,7 +1188,6 @@ ret = dediprog_open(i); if (ret == -1) { /* no dev */ - libusb_exit(usb_ctx); return 1; } else if (ret == -2) { /* busy dev */
-
Angel Pons (Code Review) -
Edward O'Callaghan (Code Review)
-
Medicine Yeh (Code Review)
-
Stefan Reinauer (Code Review)