Attention is currently required from: Alan Green, Nico Huber, Samir Ibradžić. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55695 )
Change subject: ft2232_spi: Revise comments about output pin states ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/55695/comment/520560ac_04601d62 PS1, Line 98: * TCK/SK is bit 0. : * TDI/DO is bit 1. : * TDO/DI is bit 2. : * TMS/CS is bit 3. : * GPIOL0 is bit 4. : * GPIOL1 is bit 5. : * GPIOL2 is bit 6. : * GPIOL3 is bit 7. Shouldn't this be code, e.g. macros or an enum?
#define PIN_TCK_SK (1 << 0) #define PIN_TDI_DO (1 << 1) #define PIN_TDO_DI (1 << 2) #define PIN_TMS_CS (1 << 3) #define PIN_GPIOL0 (1 << 4) #define PIN_GPIOL1 (1 << 5) #define PIN_GPIOL2 (1 << 6) #define PIN_GPIOL3 (1 << 7)