Attention is currently required from: Anastasia Klimchuk, Hsuan Ting Chen, Hsuan-ting Chen, Sam McNally.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/flashrom/+/83144?usp=email )
Change subject: ichspi: Add support for Panther Lake ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/83144/comment/01ee6570_67d88e9f?usp... : PS2, Line 9: Panther Lake
I am wondering, maybe there is a datasheet available? Asking for myself. […]
Acknowledged
File util/ich_descriptors_tool/ich_descriptors_tool.c:
https://review.coreboot.org/c/flashrom/+/83144/comment/1b306acd_b785525a?usp... : PS2, Line 123: the chipset series with the '-c' parameter and one of the possible arguments
I think you need to add panther here too
Acknowledged
https://review.coreboot.org/c/flashrom/+/83144/comment/84ef6532_8abee7cb?usp... : PS2, Line 251: else if (strcmp(csn, "panther") == 0) : cs = CHIPSET_PANTHER_LAKE;
I think the ich_descriptor_tool is run separately from flashrom. Can you run it and add as one more test scenario? (and in a commit message too) Thanks!
Sure, I have submitted CB:83149