[S] Change in flashrom[master]: meson_cross: Introduce meson cross file for DJGPP/DOS - flashrom-gerrit

13 Mar 2023


      Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73439 )
Change subject: meson_cross: Introduce meson cross file for DJGPP/DOS
......................................................................
Patch Set 3:
(1 comment)
File meson_cross/i586_djgpp_dos.txt:
https://review.coreboot.org/c/flashrom/+/73439/comment/a02d823b_3b87f958 
PS3, Line 22: gnu99
...
are gnu extensions actually needed or can one consider just std c99 ?
TL;DR: yes.
Flashrom needs some gnu extensions. For all other platforms they are handled in `meson.build` using `add_project_argument()` to make the required symbols visible. This method is not working with DJGPP. Or at least I couldn't get it to work.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/73439
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iabda73942c1e64cd46604c78533982374f78e1a4
Gerrit-Change-Number: 73439
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 13 Mar 2023 10:31:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment