Timothy Pearson has posted comments on this change. ( https://review.coreboot.org/19531 )
Change subject: Fix erase block structure on Spansion S25FL128P ......................................................................
Patch Set 2: Code-Review-2
I think what you have is a S25FL128P......0 the 0 marks 64KiB
sectors.
The exact part number printed on the Flash chip is: Spansion FL128P1F
Is the "P1" a red herring? If so, perhaps the Flashrom sources need a comment to help with this confusing aspect of the device naming.
I guess it's PI and the I is for Industrial temperature range. It's all in the datasheet ("Package Marking"). The chip you are editing should have a FL128PIFL marking. And yes, a comment with the package marking would be helpful.
The chip I have here is missing the trailing L, and the "I" really looks like a 1, but what you're describing seems reasonable looking at the code. I'll just chalk this up to a poor marking job at the factory and give the other chip name a test / update the patch to mark it verified if it works.