Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Aarya.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71119 )
Change subject: flashrom.c: Add switch for legacy impl of erasure path ......................................................................
Patch Set 13: Code-Review+2
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/71119/comment/beccc05b_360c34db PS12, Line 37: use_legacy_erase_path
You _could_ add it as a build flag however this is easy enough to toggle with a one-line commit too. […]
Yes, this would be similar to my approach that I had in mind:
1) keep `use_legacy_erase_path = true` for this patch and the next two patches 2) when CB:71119 , CB:65844 , CB:71173 are all ready, we merge them at the same time 3) send an announcement to the mailing list, announce we have new cool optimisations, explain what it is, say that developers who are interested are welcome to test. To test the feature, set `use_legacy_erase_path = false` in `flashrom.c` and rebuild flashrom. Aarya: you will send the announcement from your name, because this is your work! But I can help you with text, don't worry :) 4) give it some time: maybe a fortnight. Maybe someone reports a bug, we will look at it 5) push a commit with `use_legacy_erase_path = false` and send another announcement, that optimisations are now default. 6) we will wait for a long time, and then remove old code.
Did we answer your question? Please tell us if not!
Also, Thomas if you have a chance to comment, we are very interested in your thoughts!
-
Anastasia Klimchuk (Code Review)