Change in flashrom[master]: programmer_table: move each entry to the associated programmer source - flashrom-gerrit

7 Jun 2021


      Attention is currently required from: Nico Huber, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52946 )
Change subject: programmer_table: move each entry to the associated programmer source
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4: 
Thomas this is very cool, thank you!!
File programmer.h:
https://review.coreboot.org/c/flashrom/+/52946/comment/3648704a_a3cb7188 
PS4, Line 402: #if CONFIG_DUMMY == 1
...
Please just drop all these `#if`. The only difference it makes is […]
I am trying to understand, why it has to be an error (compile-time or link-time)? If some CONFIG_xxx is disabled, then one line with programmer_entry is not included, why an error?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52946
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3d02bd789f0299e936eb86819b3b15b5ea2bb921
Gerrit-Change-Number: 52946
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Xiang W wxjstz@126.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Mon, 07 Jun 2021 21:25:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment