Attention is currently required from: Nico Huber, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59075 )
Change subject: [RFC][WPTST] tests: test write protection ......................................................................
Patch Set 13:
(3 comments)
Patchset:
PS13: You need to explain what have you done in the latest patchset :) I was looking into diffs between PS12 and 13.
File tests/chip_wp.c:
https://review.coreboot.org/c/flashrom/+/59075/comment/bbd36603_abcc7f72 PS13, Line 260: 1 I am a bit confused, this used to be 0 (successful case) and now set_mode fails? with the same input?
https://review.coreboot.org/c/flashrom/+/59075/comment/6fdc4dcb_b52bfc67 PS13, Line 390: /* Protect first 4 KiB. */ The comment has changed to opposite meaning, but range remains the same? Maybe I am missing something, but now range covers "tail"?
-
Anastasia Klimchuk (Code Review)