Change in flashrom[master]: jlink_spi.c: Separate shutdown from failed init cleanup - flashrom-gerrit

16 Apr 2021


      Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52308 )
Change subject: jlink_spi.c: Separate shutdown from failed init cleanup
......................................................................
Patch Set 4:
(1 comment)
File jlink_spi.c:
https://review.coreboot.org/c/flashrom/+/52308/comment/f33f75ca_c3af7d6f 
PS4, Line 263: 		return 1;
Note: We do not change this return on purpose. If `jaylink_init` failed, `jaylink_ctx` may not be initialised properly, so we skip calling `jaylink_exit`.
(No action required here)
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52308
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I71f64ed38154af670d4d28b8c7914d87fbc75679
Gerrit-Change-Number: 52308
Gerrit-PatchSet: 4
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Nikolai Artemiev nartemiev@google.com
Gerrit-CC: Sam McNally sammc@google.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Fri, 16 Apr 2021 08:51:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment