Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58481 )
Change subject: libflashrom,writeprotect: add flashrom_wp_get_available_ranges()
......................................................................
Patch Set 54:
(3 comments)
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/58481/comment/97c2bceb_7989a641
PS49, Line 154: size_t
I would prefer `unsigned int` as `size_t` is officially for byte counts. […]
Done
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/58481/comment/7cedea98_f057896b
PS49, Line 811: free(list->ranges);
Better to check for NULL first, e.g. […]
Done
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58481/comment/0c8581c8_fa81d2b1
PS49, Line 171: Comparitor
Compar*a*tor
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58481
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id51f038f03305c8536d80313e52f77d27835f34d
Gerrit-Change-Number: 58481
Gerrit-PatchSet: 54
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Sun, 27 Feb 2022 22:24:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment