Attention is currently required from: Nico Huber, Angel Pons. Charles Parent has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62480 )
Change subject: ft2232_spi.c: Add FTDI FT4233H ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62480/comment/35720ccd_4fecdae1 PS1, Line 7: Add FTDI FT4233H
nit: add the file as prefix: […]
Done
https://review.coreboot.org/c/flashrom/+/62480/comment/b74cc0e3_ec90024d PS1, Line 8:
Has this change been tested? If so, how? I'd appreciate if you could add this information to the com […]
Yes it has been tested to interact with a MT25QU256. I will add the logs as well on the mailing list has flashrom indicated that this EEPROM had not been tested with this library
https://review.coreboot.org/c/flashrom/+/62480/comment/fe62fd09_5f996c4f PS1, Line 9: Change-Id: I73cee8fd2a6613a8fbc26508d99bbe67da2b4f72
You'd need to sign-off the commit as per https://flashrom. […]
Done
Patchset:
PS2: Hello Angel,
I just resolved the issues you mentionned
-
Charles Parent (Code Review)