Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/40652 )
Change subject: stlinkv3_spi: Fix memory leak ......................................................................
stlinkv3_spi: Fix memory leak
Change-Id: Ic650b43395c64b1677f6e114b0faf42a3b7b3759 Found-by: Coverity Scan #1415214 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M stlinkv3_spi.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/40652/1
diff --git a/stlinkv3_spi.c b/stlinkv3_spi.c index 7338911..9e621c2 100644 --- a/stlinkv3_spi.c +++ b/stlinkv3_spi.c @@ -495,6 +495,7 @@ msg_perr("The spispeed parameter passed with invalid format: %s\n", speed_str); msg_perr("Please pass the parameter with a simple number in kHz\n"); + free(speed_str); return -1; } free(speed_str);
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40652 )
Change subject: stlinkv3_spi: Fix memory leak ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40652 )
Change subject: stlinkv3_spi: Fix memory leak ......................................................................
Patch Set 1: Code-Review+2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40652 )
Change subject: stlinkv3_spi: Fix memory leak ......................................................................
Patch Set 1: Code-Review+2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40652 )
Change subject: stlinkv3_spi: Fix memory leak ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/40652/1/stlinkv3_spi.c File stlinkv3_spi.c:
https://review.coreboot.org/c/flashrom/+/40652/1/stlinkv3_spi.c@495 PS1, Line 495: was?
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40652 )
Change subject: stlinkv3_spi: Fix memory leak ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40652 )
Change subject: stlinkv3_spi: Fix memory leak ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/40652/1/stlinkv3_spi.c File stlinkv3_spi.c:
https://review.coreboot.org/c/flashrom/+/40652/1/stlinkv3_spi.c@495 PS1, Line 495:
was?
perhaps, but not in this commit? :-)
Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/40652 )
Change subject: stlinkv3_spi: Fix memory leak ......................................................................
stlinkv3_spi: Fix memory leak
Change-Id: Ic650b43395c64b1677f6e114b0faf42a3b7b3759 Found-by: Coverity Scan #1415214 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/40652 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M stlinkv3_spi.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
diff --git a/stlinkv3_spi.c b/stlinkv3_spi.c index 7338911..9e621c2 100644 --- a/stlinkv3_spi.c +++ b/stlinkv3_spi.c @@ -495,6 +495,7 @@ msg_perr("The spispeed parameter passed with invalid format: %s\n", speed_str); msg_perr("Please pass the parameter with a simple number in kHz\n"); + free(speed_str); return -1; } free(speed_str);
-
Angel Pons (Code Review) -
Edward O'Callaghan (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Stefan Reinauer (Code Review)