Attention is currently required from: Felix Singer, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66782 )
Change subject: tree/: Convert flashchip write func ptr to enumerate
......................................................................
Patch Set 9:
(1 comment)
File include/flash.h:
https://review.coreboot.org/c/flashrom/+/66782/comment/e9188252_69f76bd8
PS8, Line 229: chip_write_func
There is an inconsistency in enum names at the moment: […]
The functions are all inconsistent identifiers, I did best efforts not to be too confusing as a patch and not be overlapping with a rename patch. My take would be to follow up with a make everything consistent rename patch.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66782
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I80149de169464b204fb09f1424a86fc645b740fd
Gerrit-Change-Number: 66782
Gerrit-PatchSet: 9
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 26 Sep 2022 04:35:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment