Attention is currently required from: Anastasia Klimchuk, Matti Finder, Nikolai Artemiev, Stefan Reinauer.
Sergii Dmytruk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85075?usp=email )
Change subject: flashchips: Skip "WP untested" message for SFDP-capable chip
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
The comment just above the line with tested status indicates that the idea always was to mark everyt […]
I wonder if `chip->tested.wp` should be ignored for chips with `chip->decode_range == NO_DECODE_RANGE_FUNC`.
Commit Message:
https://review.coreboot.org/c/flashrom/+/85075/comment/085cc690_1a43cab9?usp... :
PS2, Line 12: SDFP chip and what would you report?
`SFDP`
--
To view, visit
https://review.coreboot.org/c/flashrom/+/85075?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I7e945389895a8042df3aaae72bccf73405be8651
Gerrit-Change-Number: 85075
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Matti Finder
matti.finder@gmail.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Matti Finder
matti.finder@gmail.com
Gerrit-Comment-Date: Sun, 10 Nov 2024 22:29:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org