[M] Change in flashrom[master]: cli_classic.c: Factor out rom bus limits exceeded validation
Attention is currently required from: Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68661 )
Change subject: cli_classic.c: Factor out rom bus limits exceeded validation ......................................................................
Patch Set 3: Code-Review+1
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68661/comment/8715579b_a0bc1215 PS3, Line 9: Cave nit: `Carve` with an `r`?
https://review.coreboot.org/c/flashrom/+/68661/comment/a2996726_e2bd565b PS3, Line 11: it's nit: possessive `its`
https://review.coreboot.org/c/flashrom/+/68661/comment/a15377a7_40c611d5 PS3, Line 11: pairingings nit: There's an extra `ing` in `pairings`
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/68661/comment/af0e8254_567b93a9 PS3, Line 565: exceed nit: exceed*ed*
https://review.coreboot.org/c/flashrom/+/68661/comment/b73ce3ad_f0ae31ce PS3, Line 565: relevent nit: relev*a*nt
https://review.coreboot.org/c/flashrom/+/68661/comment/d058342c_00ca2b35 PS3, Line 575: (bitcount(commonbuses) > limitexceeded) nit: drop extra set of parentheses
-
Angel Pons (Code Review)