Attention is currently required from: Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69474 )
Change subject: flashrom.c: Replace 'exit(1)' leaks with return codes on err paths ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69474/comment/96bce863_a544e211 PS3, Line 11: to occur. Sorry, what exactly leaks if the program terminates? If `malloc()` or similar failed, it's likely because of a bigger problem with the system that is outside of flashrom's control; it's possible that flashrom may not be able to gracefully handle the situation.
That being said, getting rid of `exit()` calls makes sense for libflashrom users, as it prevents the callers from trying to handle errors.