Attention is currently required from: Anastasia Klimchuk, Brian Norris, Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81545?usp=email )
Change subject: udelay: only use OS time for delays, except on DOS ......................................................................
Patch Set 9:
(2 comments)
Patchset:
PS9:
Peter, this looks cool ! What do you think about sharing the link to the patch on the mailing list, […]
Yup, good idea. Added a note to the existing thread.
File tests/udelay.c:
https://review.coreboot.org/c/flashrom/+/81545/comment/2ab2c0fc_d1278800 : PS9, Line 41: This test could fail spuriously on a heavily-loaded system
From my side, I would want to keep the test, with both lower and upper bound. […]
Carrying a patch to the test on ChromeOS seems okay to me, but I'm not particularly attached to testing the upper bound anyway since it doesn't feel very right to me to have a test that can fail when run on a machine that's busy doing other things.
The invariant that the implementation needs to enforce is that it waits for no less time than requested; the upper bound is only important in that waiting for a longer time might result in a poor user experience. The question is whether we consider a poor user experience a true error, and if so what threshold we care about.
-
Peter Marheine (Code Review)