Attention is currently required from: Thomas Heijligen.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67479 )
Change subject: spi: Make 'default_spi_write_aai' the default unless defined ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67479/comment/fb901c4e_6c4057e1 PS1, Line 9: Drop the explicit need to specify the default 'default_spi_write_aai'
Please mention the struct where you perform the changes on
Done
Patchset:
PS1:
Two things: […]
Addressed the first part in the commit message by making clear the mathematical constraint here in precise terms.
Regarding the second part. I am not sure renaming everything in the tree with a prefix or suffix of optimised. For one that seems like a different patch to this one that is semantic and secondly that line of reasoning means everything non-NULL is a 'optimised/optional' version which I am not sure makes sense either - 'custom' would be a closer term to the reality but even then makes no sense to use in the function identifier. All we are saying here is to make function pointers in the struct RAII where a default construction of the type into a initial value is valid.
To address the concerns of the second part a alternative compromise would perhaps just be a code comment above spi.c:spi_aai_write().