Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev.
Liam Flaherty has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68364 )
Change subject: raiden_debug_spi: Remove fixme with explanation ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68364/comment/e9dd127e_6f87e10b PS1, Line 7: debug_raiden_spi
raiden_debug_spi (should be the programmer name)
Done
https://review.coreboot.org/c/flashrom/+/68364/comment/e28f99c5_2ca66cc3 PS1, Line 9: The raiden_debug_spi programmer will query the connected USB devices and : match against criteria other than the pid rather than iterate through the : vid:pid table.
Max width of commit message is 72 chars (see https://www.flashrom. […]
Done
https://review.coreboot.org/c/flashrom/+/68364/comment/f0385318_93f71a0f PS1, Line 14: TICKET=https://ticket.coreboot.org/issues/394
I am terribly sorry, I made a mistake and told you to do the wrong thing, it actually should be […]
Done
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/68364/comment/aee1b36a_b19850fc PS1, Line 354: // rather than looking for a device with a specific vid:pid.
Either approach seems fine. But if you want to go with `1. […]
Done
-
Liam Flaherty (Code Review)