Attention is currently required from: Nico Huber, Angel Pons, Light.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62764 )
Change subject: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow error
......................................................................
Patch Set 12:
(2 comments)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62764/comment/06fb063e_67b36cee
PS6, Line 507: assert(j >= 12);
If `num_regions` is 10, the second loop never runs. This doesn't change […]
Oh yes, sorry that's all good, I missed! I am marking this as resolved then?
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62764/comment/0f3da6d7_81b9244a
PS12, Line 505: ++j
Is there a reason for this change (from `j++` to `++j`) ? If not (not an intentional change), then better return back as it was. Thanks!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62764
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5921cc571f3dca5188ca1973dba6ececbcbe2f39
Gerrit-Change-Number: 62764
Gerrit-PatchSet: 12
Gerrit-Owner: Light
aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Light
aarya.chaumal@gmail.com
Gerrit-Comment-Date: Sun, 27 Mar 2022 07:16:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Light
aarya.chaumal@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment