Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68162 )
Change subject: meson: Move programmer test sources into programmer definition ......................................................................
Patch Set 16: Code-Review+1
(2 comments)
File meson.build:
https://review.coreboot.org/c/flashrom/+/68162/comment/a6448335_ee63435a PS16, Line 191: 'test_srcs' : Is it possible to align all `:` ? Maybe it's just me... but it jumps into my eyes that `:`s are not aligned, and same for the loop below :)
File tests/meson.build:
https://review.coreboot.org/c/flashrom/+/68162/comment/08ceadfa_504bbc2b PS10, Line 32: p_data += { : 'testsrc' : p_data.get('testsrc', []), : } : srcs += p_data.get('testsrc')
I just noticed I made a typo and that's why it didn't work. oopsie 😄 […]
Good to know it works! And looks even better in the latest patchset!