[L] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par/spi_master
Attention is currently required from: Thomas Heijligen, Jonathon Hall, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 )
Change subject: drivers: Move (un)map_flash_region from programmer to par/spi_master ......................................................................
Patch Set 7:
(2 comments)
Patchset:
PS5:
Could you update those with the current master (minor merge conflicts) and separate them from CB:673 […]
Yes. I updated CB:67404 to sit off HEAD so this mapping stuff is decoupled from the delay stuff. I locally rebased your patch on top of CB:67404 and things look much easier to read. There is still some shared ideas/artifacts with CB:67478 and your patch which makes me think we could split this patch into two but with CB:67404 as the base it isn't too hard then to see what is being done.
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/2c94bd75_3d6afb87 PS2, Line 1865: &mapper_phys
The mapper is back for this SPI master now, I don't think it is needed but I'll leave that to be cha […]
I wonder if this is the part that is the second patch here and if the parallel framework part of the patch is a separable change from that of plumb spi masters?
I know it's always a little bit of a bother to split patches however I think both Thomas and I share the common concern with how many branches there are in sorting out mapping so just granulating the changes the best we can is perhaps a good tactic in dealing with unrolling this techdebt. Thanks in advanced for your energy!
-
Edward O'Callaghan (Code Review)