[M] Change in flashrom[main]: flashchips: adding GD25LB512MF/GD25LR512MF

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim.

Anastasia Klimchuk has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83899?usp=email )

Change subject: flashchips: adding GD25LB512MF/GD25LR512MF
......................................................................

Patch Set 1:

(4 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/83899/comment/e73d9e58_7de21e43?usp... :
PS1, Line 14: The datasheet is under controll.
            : You can either refer to GD25LB512MF datasheet.
            : Or I send you a copy.
If you say the both datasheets is identical, that's fine, no need to send me the second one. You can remove these 3 lines from commit message.

But please have a look at my other comment about testing. Thank you!

https://review.coreboot.org/c/flashrom/+/83899/comment/ca1d460c_e41f423a?usp... :
PS1, Line 18: Tested
Have you tested both models? Maybe you can add here "tested both models".

File flashchips.c:

https://review.coreboot.org/c/flashrom/+/83899/comment/ffd19cd3_5b19ea70?usp... :
PS1, Line 7109: BP3
SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD here? (instead of BP3)

https://review.coreboot.org/c/flashrom/+/83899/comment/19409ba3_d39cf2bb?usp... :
PS1, Line 7118: tb     = {STATUS1, 6, RW},
I think you need to add a usual comment here
> Called BP4 in datasheet, acts like TB