Attention is currently required from: Felix Singer, Thomas Heijligen, Alexander Goncharov.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68247 )
Change subject: util: add bash completion script ......................................................................
Patch Set 12: Code-Review+1
(3 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/68247/comment/1928b585_4e31f096 PS9, Line 1032: $(PROGRAM).8 $(PROGRAM).8.html $(PROGRAM).bash $(BUILD_DETAILS_FILE)
What do you mean? I just added `$(PROGRAM). […]
It's a continuation of the previous line, hence further indented.
File meson.build:
https://review.coreboot.org/c/flashrom/+/68247/comment/1fc5422a_c0e60fc1 PS9, Line 646: .bash
No way. […]
Only option I could find is to provide a custom install_script.
File util/flashrom.bash-completion.tmpl:
https://review.coreboot.org/c/flashrom/+/68247/comment/b21f1b96_fc9842b5 PS9, Line 43: OPTS="--help
It makes no difference for this task. […]
I agree, it shouldn't be necessary. If `compgen` can handle the tabs, it should also be able to handle other whitespace.
-
Nico Huber (Code Review)