Attention is currently required from: Edward O'Callaghan, Daniel Campello, Anastasia Klimchuk. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59532 )
Change subject: [FIX ME] tests: Add test for extract operation ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
Daniel, Edward I added you because I found your names in commit ce983bccaab450d358854494f15c2d8a1846 […]
Failing looks like correct behavior to me, since `read_flash_to_file` will never have a meaningful result beyond the side-effect of writing to a file; failing to tell it what file you want is an error.
The confusion seems to have come from the Chromium fork of flashrom checking if the filename is NULL in `read_flash_to_file` and then skipping `write_buf_to_file` if no filename is given. That behavior seems wrong because a user should simply not call `read_flash_to_file` if they don't have a file, otherwise it would be doing the work to read the flash then throwing away the results.
-
Peter Marheine (Code Review)