Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48779 )
Change subject: sb600spi.c: Detect rev 0x51 as Promontory ......................................................................
sb600spi.c: Detect rev 0x51 as Promontory
As reported on the mailing list.
Change-Id: Iff8340633021fde1dc32572ab5f5da85df5d9048 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M sb600spi.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/48779/1
diff --git a/sb600spi.c b/sb600spi.c index 2e27cee..ef9da4b 100644 --- a/sb600spi.c +++ b/sb600spi.c @@ -129,7 +129,7 @@ * The revisions I have found by searching various lspci * outputs are as follows: 0x4b, 0x59 & 0x61. */ - } else if (rev == 0x4b || rev == 0x59 || rev == 0x61) { + } else if (rev == 0x4b || rev == 0x51 || rev == 0x59 || rev == 0x61) { msg_pdbg("Promontory (rev 0x%02x) detected.\n", rev); return CHIPSET_PROMONTORY; } else {
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48779 )
Change subject: sb600spi.c: Detect rev 0x51 as Promontory ......................................................................
Patch Set 1: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/48779 )
Change subject: sb600spi.c: Detect rev 0x51 as Promontory ......................................................................
sb600spi.c: Detect rev 0x51 as Promontory
As reported on the mailing list.
Change-Id: Iff8340633021fde1dc32572ab5f5da85df5d9048 Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/48779 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M sb600spi.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/sb600spi.c b/sb600spi.c index 2e27cee..ef9da4b 100644 --- a/sb600spi.c +++ b/sb600spi.c @@ -129,7 +129,7 @@ * The revisions I have found by searching various lspci * outputs are as follows: 0x4b, 0x59 & 0x61. */ - } else if (rev == 0x4b || rev == 0x59 || rev == 0x61) { + } else if (rev == 0x4b || rev == 0x51 || rev == 0x59 || rev == 0x61) { msg_pdbg("Promontory (rev 0x%02x) detected.\n", rev); return CHIPSET_PROMONTORY; } else {
-
Angel Pons (Code Review) -
Edward O'Callaghan (Code Review)