Nico Huber has posted comments on this change. ( https://review.coreboot.org/22274 )
Change subject: ichspi: Disable software sequencing by default for Skylake
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/22274/1/ichspi.c
File ichspi.c:
https://review.coreboot.org/#/c/22274/1/ichspi.c@1957
PS1, Line 1957: }
Would it make sense to move this to line 1800, closer to where ich_spi_mode
I've intentionally placed it here. This way we still see from the
output if there was any other reason to use hwseq.
--
To view, visit
https://review.coreboot.org/22274
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a13fb9c3ca679b3f7d39ad1dc56d5efdc80045b
Gerrit-Change-Number: 22274
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 05 Nov 2017 10:57:18 +0000
Gerrit-HasComments: Yes