Attention is currently required from: Shiyu Sun, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49785 )
Change subject: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49785/comment/076eabd5_4e1ff7cc PS2, Line 9: Gpio 88 toggle is used as write protection disable/enable now : and we need that to happen at the initialization of programmer.
Since Shiyu is unavailable and this seems to fix a bug where 'Block protection could not be disabled […]
Alright. Since flashrom patches can be submitted even when there are unresolved comments, let's keep this comment as unresolved until we get a reply from Shiyu.