Attention is currently required from: Wonkyu Kim, Edward O'Callaghan, Anastasia Klimchuk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62783 )
Change subject: ichspi: Add support for Meteor Lake ......................................................................
Patch Set 3:
(2 comments)
File util/ich_descriptors_tool/ich_descriptors_tool.c:
https://review.coreboot.org/c/flashrom/+/62783/comment/878f35c1_c37a51c6 PS3, Line 130: "\t- "gemini" for Intel's Gemini Lake SoC.\n"
maybe the SoC are grouped around here though.
ah, I can do that, just that MTL is next to ADL hence kept at line 141. If you want, I can move it here as well.
https://review.coreboot.org/c/flashrom/+/62783/comment/64ae1680_ad605932 PS3, Line 241: else if (strcmp(csn, "meteor") == 0) : cs = CHIPSET_METEOR_LAKE;
should this be moved down a bit to be ordered in the same way the others are to be consistent?
same reason as other file.
-
Subrata Banik (Code Review)