Nico Huber has posted comments on this change. ( https://review.coreboot.org/23263 )
Change subject: Add support for reading the current flash contents from a file
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/#/c/23263/9/cli_classic.c
File cli_classic.c:
https://review.coreboot.org/#/c/23263/9/cli_classic.c@63
PS9, Line 63: -C |
drop `-C |`
https://review.coreboot.org/#/c/23263/9/cli_classic.c@114
PS9, Line 114: OPTION_FLASH_CONTENTS = 0x0101
Nit, you only have to specify a number for the first value. Last
line should have a trailing comma too, so you don't have to add
that later when the list gets longer.
--
To view, visit
https://review.coreboot.org/23263
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf153b6955f37779ae9bfb228a434ed10c304947
Gerrit-Change-Number: 23263
Gerrit-PatchSet: 9
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Kocialkowski
contact@paulk.fr
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 06 Feb 2018 22:27:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No