[S] Change in flashrom[master]: flashrom.c:Enable erase path optimisation - flashrom-gerrit

2 May 2023


      Attention is currently required from: Aarya, Nikolai Artemiev, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74872 )
Change subject: flashrom.c:Enable erase path optimisation
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
...
This change breaks the unit test for full chip erase when write protect is enabled (https://ticket. […]
I don't know what the bug is however it seems to indicate something is wrong in the new path `get_region` not being set I don't think is the root cause of anything, I would expect that to be `NULL` for most drivers.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/74872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie13e43b18b20dbb956b569e554953a19eb32ea22
Gerrit-Change-Number: 74872
Gerrit-PatchSet: 2
Gerrit-Owner: Aarya aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Aarya aarya.chaumal@gmail.com
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Tue, 02 May 2023 02:00:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aarya aarya.chaumal@gmail.com
Gerrit-MessageType: comment