Attention is currently required from: Angel Pons, qianfan, Nicholas Chin.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70529 )
Change subject: Add initial CH347T SPI programmer ......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9: qianfan, I wanted to check with you about your patch. As you know, as a complete coincidence, we now have two patches implementing a programmer for ch347: CB:70573 and yours. After several discussions, we decided to take CB:70573 as a baseline patch for ch347.
There are technical reasons for this decision: 1) CB:70573 has less layers of indirection 2) the preference is for arrays and manual shifts/masks because they are the only portable way of guaranteeing things end up in the right place 3) the general style (naming, function ordering) follows the style of flashrom more closely 4) CB:70573 does not use global state for a programmer
Important thing for now is to figure out if there are some useful features from your patch that can be introduced on the top of CB:70573 ? What do you think?
-
Anastasia Klimchuk (Code Review)