Attention is currently required from: Daniel Maslowski, Sophie van Soest, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56055 )
Change subject: Enable probing for IT8620 allowing to use the `dualbiosindex` parameter.
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/56055/comment/c5bc28b7_72bcf80c
PS4, Line 7: Enable chipset it97spi: 0x8620 Gigabyte-Z97-HD3
I squashed them into one commit to have a clean patch. […]
From this headline one can not relate that you are marking Z97 as OK. That's why I suggested you create a seperate patch for this since it might be hard finding a meaningful headline for both changes. We try to follow the common 50/72 rule for commit messages, 50 characters for headlines and 72 for the body.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/56055
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0be9effe4a2f1f9699e016c7fc45018c9c522cbc
Gerrit-Change-Number: 56055
Gerrit-PatchSet: 8
Gerrit-Owner: Sophie van Soest
sophie@entropie.rocks
Gerrit-Reviewer: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Daniel Maslowski
info@orangecms.org
Gerrit-Attention: Sophie van Soest
sophie@entropie.rocks
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sun, 04 Jul 2021 12:25:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Sophie van Soest
sophie@entropie.rocks
Gerrit-MessageType: comment