Attention is currently required from: Balázs Vinarz, Keith Hui, Nico Huber.
Anastasia Klimchuk has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/flashrom/+/23053?usp=email )
Change subject: Fwd: Software info for Willem/EZOflash ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
have the user specify the protocol via programmer options
If this is fine for the user, this is a good option. Would the user know which protocol they need? For example, if you were the user?
dummyflasher.c can initialise more than one bus, and the desired option is set via programmer param. dummyflasher is an emulator-programmer, but it will do as an example how to init one bus or the other depending on the param.
Also, this can be done step-by-step, doesn't have to be in one commit. First commit adds programmer and support for spi. Second commit can add programmer param, and more options (parallel). If default option stays the same (default what happens without param provided), this should be fine.
Adding new programmer will be a large commit already, and lots of work, I think planning multiple commits will help.
File meson.build:
https://review.coreboot.org/c/flashrom/+/23053/comment/071e5f0a_231e3b68?usp... : PS2, Line 500:
we might need to use the ezo here as well to maintain consistency, but that wouldn't mention that th […]
yes, let's use `ezo` it seems it can be made to work with not only SPI
-
Anastasia Klimchuk (Code Review)