Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62851 )
Change subject: hwaccess_x86_msr: rename rdmsr, wrmsr to read_cpu_msr, write_cpu_msr ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1: I first thought, it's called rdmsr/wrmsr everywhere, so we might discourage from using these functions by renaming. However, after looking at the code, that might be a good thing :D
Should be testable by comparing binaries. They shouldn't change, right?
File hwaccess_x86_msr.c:
https://review.coreboot.org/c/flashrom/+/62851/comment/d4c2fd82_0d66f05b PS1, Line 296: /* rdmsr() and wrmsr() are provided by DirectHW which needs neither setup nor cleanup. */ Do we have all necessary #include's in this file, though?