Change in flashrom[master]: tests: Add unit test to run init/shutdown for mec1308.c, ene_lpc.c
Attention is currently required from: Nico Huber, Angel Pons, Simon Glass. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51487 )
Change subject: tests: Add unit test to run init/shutdown for mec1308.c, ene_lpc.c ......................................................................
Patch Set 14:
(4 comments)
Patchset:
PS13:
another option is just to submit it. […]
thank you! :)
PS13:
I rebased this on the top of io_mock.h. […]
update: #3 done.
For #1 and #2 I would do them separately after this one, but tell me what you all think.
File tests/io_mock.h:
https://review.coreboot.org/c/flashrom/+/51487/comment/c23930c3_c0306274 PS13, Line 37: unsigned char
I took these types from a Linux manual page, is there something […]
I took these types from hwaccess_x86_io.h because I thought, these are mocks for outx/inx and the mocks should have the same signatures as real functions. Do you know why hwaccess has different types than Linux manual page? Maybe I am looking in the wrong place? But technically, we are mocking functions in hwaccess?
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/51487/comment/77e9edcf_0e98bf38 PS13, Line 26: static struct io_mock *current_io = NULL;
This could just be `const`, I guess, as there is no intention […]
oh yes thank you... warning gone!
-
Anastasia Klimchuk (Code Review)