Attention is currently required from: Sam McNally, Edward O'Callaghan, Anastasia Klimchuk.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62320 )
Change subject: tests/: Add file path and flags validation to open() calls
......................................................................
Patch Set 16:
(2 comments)
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/62320/comment/ecfd8858_8acc6d71
PS14, Line 201: io_mock_register(&chip_io);
related: https://review.coreboot. […]
Done. Rebased on top of that change too
https://review.coreboot.org/c/flashrom/+/62320/comment/3a7cf6d7_8f140da8
PS14, Line 216: io_mock_register(NULL);
`io_mock_register(NULL)` can be moved into `teardown` because it just repeats at the end of each tes […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62320
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I892fa1ecee26ebce9640893edbb228fa9aa7b0b6
Gerrit-Change-Number: 62320
Gerrit-PatchSet: 16
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 11 Apr 2022 17:02:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment