Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64031 )
Change subject: meson: use static library for tests
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File tests/meson.build:
https://review.coreboot.org/c/flashrom/+/64031/comment/d42c4c2a_35ffc47c
PS1, Line 93: files(
: 'io_mock.c',
: 'tests.c',
: 'libusb_wraps.c',
: 'helpers.c',
: 'flashrom.c',
: 'spi25.c',
: 'lifecycle.c',
: 'layout.c',
: 'chip.c',
: ),
I feel like the src array should be separated out from the control block.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64031
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd
Gerrit-Change-Number: 64031
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Fri, 06 May 2022 01:23:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment