Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59278 )
Change subject: programmer.h: Make pacc global state static local
......................................................................
Patch Set 3:
(1 comment)
File programmer.h:
https://review.coreboot.org/c/flashrom/+/59278/comment/41ef961f_07239bc2
PS3, Line 122: // FIXME: Fix chipset_enable.c usage and remove pcidev_set_pacc().
Even if `pacc` no longer has global visibility, it's still global state. To remove `pcidev_set_pacc()`, the alternative `struct pci_access` used in chipset_enable.c should be passed to the functions that need it by parameter.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59278
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3bea1b93a7ca81dd42a64eec1e49a10f1fbda850
Gerrit-Change-Number: 59278
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Sun, 14 Nov 2021 15:30:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment