Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/83149?usp=email )
Change subject: util/ich_descriptors_tool: Add Panther Lake SoC to supported chipsets ......................................................................
util/ich_descriptors_tool: Add Panther Lake SoC to supported chipsets
This change extends the ich_descriptors_tool to recognize and process descriptors for Intel's upcoming Panther Lake SoC.
BUG=b:347669091 TEST=ich_descriptors_tool is able to detect "panther" chipset and show below information:
./util/ich_descriptors_tool/ich_descriptors_tool
Need the file name of a descriptor image to read from. usage: './util/ich_descriptors_tool/ich_descriptors_tool -f <image file name> [-c <chipset name>] [-d]' ... ... To also print the data stored in the descriptor straps you have to indicate the chipset series with the '-c' parameter and one of the possible arguments: - "ich8", - "ich9", - "ich10", - "apollo" for Intel's Apollo Lake SoC. - "gemini" for Intel's Gemini Lake SoC. - "jasper" for Intel's Jasper Lake SoC. - "meteor" for Intel's Meteor Lake SoC. - "panther" for Intel's Panther Lake SoC. ... ... - "300" or "cannon" for Intel's 300 series chipsets. - "400" or "comet" for Intel's 400 series chipsets. - "500" or "tiger" for Intel's 500 series chipsets. - "600" or "alder" for Intel's 600 series chipsets.
Change-Id: I17d616d346daca15b43eb294401ac0c672b64c4a Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/83149 Reviewed-by: Anastasia Klimchuk aklm@chromium.org Reviewed-by: Sam McNally sammc@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/ich_descriptors_tool/ich_descriptors_tool.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Sam McNally: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, approved
diff --git a/util/ich_descriptors_tool/ich_descriptors_tool.c b/util/ich_descriptors_tool/ich_descriptors_tool.c index 844d8e9..09587f7 100644 --- a/util/ich_descriptors_tool/ich_descriptors_tool.c +++ b/util/ich_descriptors_tool/ich_descriptors_tool.c @@ -129,6 +129,7 @@ "\t- "gemini" for Intel's Gemini Lake SoC.\n" "\t- "jasper" for Intel's Jasper Lake SoC.\n" "\t- "meteor" for Intel's Meteor Lake SoC.\n" +"\t- "panther" for Intel's Panther Lake SoC.\n" "\t- "5" or "ibex" for Intel's 5 series chipsets,\n" "\t- "6" or "cougar" for Intel's 6 series chipsets,\n" "\t- "7" or "panther" for Intel's 7 series chipsets.\n" @@ -248,6 +249,8 @@ cs = CHIPSET_ELKHART_LAKE; else if (strcmp(csn, "meteor") == 0) cs = CHIPSET_METEOR_LAKE; + else if (strcmp(csn, "panther") == 0) + cs = CHIPSET_PANTHER_LAKE; }
ret = read_ich_descriptors_from_dump(buf, len, &cs, &desc);