Change in flashrom[master]: flashchips: upstream AT25SF128A from chromiumos

[Alan Green (Code Review)]

Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/37543 )

Change subject: flashchips: upstream AT25SF128A from chromiumos
......................................................................

flashchips: upstream AT25SF128A from chromiumos

Upstream the AT25SF128A chip from chromiumos repository.

Change-Id: I6349aa41eee0c997aaa507383aff7ce26441d24f
---
M flashchips.c
M flashchips.h
2 files changed, 39 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/37543/1

diff --git a/flashchips.c b/flashchips.c
index 4324c11..fc4cdff 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -2293,6 +2293,44 @@

{
    	.vendor		= "Atmel",
+		.name		= "AT25SF128A",
+		.bustype	= BUS_SPI,
+		.manufacture_id	= ATMEL_ID,
+		.model_id	= ATMEL_AT25SF128A,
+		.total_size	= 16384,
+		.page_size	= 256,
+		.feature_bits	= FEATURE_WRSR_WREN | FEATURE_OTP,
+		.tested		= TEST_OK_PR,
+		.probe		= probe_spi_rdid,
+		.probe_timing	= TIMING_ZERO,
+		.block_erasers	=
+		{
+			{
+				.eraseblocks = { {4 * 1024, 4096} },
+				.block_erase = spi_block_erase_20,
+			}, {
+				.eraseblocks = { {32 * 1024, 512} },
+				.block_erase = spi_block_erase_52,
+			}, {
+				.eraseblocks = { {64 * 1024, 256} },
+				.block_erase = spi_block_erase_d8,
+			}, {
+				.eraseblocks = { {16 * 1024 * 1024, 1} },
+				.block_erase = spi_block_erase_60,
+			}, {
+				.eraseblocks = { {16 * 1024 * 1024, 1} },
+				.block_erase = spi_block_erase_c7,
+			}
+		},
+		.printlock	= spi_prettyprint_status_register_bp4_srwd,
+		.unlock		= spi_disable_blockprotect_bp4_srwd,
+		.write		= spi_chip_write_256,
+		.read		= spi_chip_read,
+		.voltage	= {1700, 2000},
+	},
+
+	{
+		.vendor		= "Atmel",
    	.name		= "AT25SF161",
    	.bustype	= BUS_SPI,
    	.manufacture_id	= ATMEL_ID,
diff --git a/flashchips.h b/flashchips.h
index 2c2da6c..5609527 100644
--- a/flashchips.h
+++ b/flashchips.h
@@ -151,6 +151,7 @@
 #define ATMEL_AT25SF081		0x8501
 #define ATMEL_AT25SF161		0x8601
 #define ATMEL_AT25SL128A	0x4218
+#define ATMEL_AT25SF128A	0x8901 /* Adesto AT25SF128A */
 #define ATMEL_AT26DF041		0x4400
 #define ATMEL_AT26DF081		0x4500	/* guessed, no datasheet available */
 #define ATMEL_AT26DF081A	0x4501

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37543 )

Change subject: flashchips: upstream AT25SF128A from chromiumos
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/flashrom/+/37543/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/37543/1//COMMIT_MSG@2 
PS1, Line 2: Author:     Alan Green 
Can you extract the original commit message from 1fa87e05 with author and signoff lines and include the original hash 1fa87e05 in the commit message?

Something like:

```
flashchips: [DOWNSTREAM]: Add support for Adesto AT25SF128A

The following adds support for the Adesto AT25SF128A-SHB-T part.
We have varied the correct chip name is reported as well as write
and read 16MBytes of random data and verified the checksum's match. Further, --wp-list appears to report the correct ranges.

BUG=None
BRANCH=none
TEST=Ran flashrom with a Dediprog SF100, RW random data and checksum matched.

Original-Change-Id: Ic22ca588f33753fdf492e8445324bcc0a809d3e2
Signed-off-by: Edward O'Callaghan 
Original-Reviewed-on: https://chromium-review.googlesource.com/1593201
Tested-by: Martin Roth 
Reviewed-by: Martin Roth 
```

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37543 )

Change subject: flashchips: upstream AT25SF128A from chromiumos
......................................................................

Patch Set 1: Code-Review+1

Any news?

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37543 )

Change subject: flashchips: upstream AT25SF128A from chromiumos
......................................................................

Patch Set 1: Code-Review+2

[Alan Green (Code Review)]

Alan Green has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/37543 )

Change subject: flashchips: upstream AT25SF128A from chromiumos
......................................................................

Abandoned

old patch