Change in flashrom[master]: nicintel_spi.c: Cache FLA register value - flashrom-gerrit

4 Oct 2021


      Attention is currently required from: Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55720 )
Change subject: nicintel_spi.c: Cache FLA register value
......................................................................
Patch Set 2:
(1 comment)
File nicintel_spi.c:
https://review.coreboot.org/c/flashrom/+/55720/comment/0b96d0db_1b4bc71a 
PS2, Line 122: pci_mmio_readl
...
If somebody else is still in charge, could the register value still […]
Good question, I'd have to read the datasheet. To be safe, I think keeping the last value read is the right thing to do.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/55720
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4013a71ec498be977f62fe2531ac8770bfffadcd
Gerrit-Change-Number: 55720
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Idwer Vollering vidwer@gmail.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Mon, 04 Oct 2021 14:01:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment