Attention is currently required from: Edward O'Callaghan, Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73102 )
Change subject: cli_classic: include a fallback inplementation of getopt
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS1:
Not really. I just copied and tested it. […]
Better now?
File cli_getopt.c:
https://review.coreboot.org/c/flashrom/+/73102/comment/977620c2_50b43c74
PS1, Line 13: #if 0
I'm not yet sure how exactly handle this. I don't want to use the msg_** form flash.h. […]
For now I've used flashroms message system. We can replace this along with the rest when it's time.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/73102
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6ebbde075014e3b45b0f9e04b34b72aa969e1197
Gerrit-Change-Number: 73102
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 03 Mar 2023 20:32:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment