Attention is currently required from: Edward O'Callaghan.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59276 )
Change subject: pcidev: Move pci_get_dev() logic into canonical place
......................................................................
Patch Set 3:
(1 comment)
File board_enable.c:
https://review.coreboot.org/c/flashrom/+/59276/comment/f98b7a1f_d0152967
PS3, Line 1097: dev = pcidev_clonedev(dev);
I didn't understand what is actionable here? […]
Yeah, sorry for the earlier suggestion, I didn't realize how odd things
are.
It should be obvious what the function does. So yes, putting the 1 in the
name would work. (I'm not sure if this case is worth a function, though.)
I'd prefer something like `pcidev_get_function1(dev)`, or
`pcidev_get_fn1(dev)` or `pcidev_get_function(dev, fn)`. We really
shoudn't make the code more confusing.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59276
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id9ce055d5e5d347520ec5002b8c6548e60eaa0a7
Gerrit-Change-Number: 59276
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Thu, 24 Feb 2022 11:51:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment