Change in flashrom[master]: spi25_statusreg.c: add SR3 read/write support - flashrom-gerrit

5 Apr 2022


      Attention is currently required from: Nico Huber.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60230 )
Change subject: spi25_statusreg.c: add SR3 read/write support
......................................................................
Patch Set 9:
(1 comment)
File flash.h:
https://review.coreboot.org/c/flashrom/+/60230/comment/407f5415_fe88f429 
PS2, Line 148: FEATURE_SR3
...
As mentioned above SR2 is a different case no matter what we do, as […]
I think Nico is right and this flag is not actually useful, because it never on its own controls whether SR3 access will occur. Removed it.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/60230
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id987c544c02da2b956e6ad2c525265cac8f15be1
Gerrit-Change-Number: 60230
Gerrit-PatchSet: 9
Gerrit-Owner: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Tue, 05 Apr 2022 15:35:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Comment-In-Reply-To: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment